feat: Create psql DB in the CF provisioner #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Open
alecthomas
reviewed
Nov 6, 2024
|
|
||
| "connectrpc.com/connect" | ||
| "github.com/aws/aws-sdk-go-v2/service/cloudformation" | ||
| "github.com/aws/aws-sdk-go-v2/service/cloudformation/types" | ||
| "github.com/aws/aws-sdk-go-v2/service/secretsmanager" | ||
| _ "github.com/lib/pq" |
There was a problem hiding this comment.
We use pgx, let's not have two PG drivers.
| return fmt.Errorf("failed to group outputs by property name: %w", err) | ||
| } | ||
|
|
||
| fmt.Fprintf(os.Stderr, "byName: %v\n", byName) |
| return fmt.Errorf("failed to get username and password from secret ARN: %w", err) | ||
| } | ||
|
|
||
| to.ReadDsn = endpointToDSN(*byName[PropertyDBReadEndpoint].OutputValue, resourceID, 5432, username, password) |
There was a problem hiding this comment.
These blind pointer deferences are horrifying.
|
|
||
| func endpointToDSN(endpoint, database string, port int, username, password string) string { | ||
| urlEncodedPassword := url.QueryEscape(password) | ||
| return fmt.Sprintf("postgres://%s:%d/%s?user=%s&password=%s", endpoint, port, database, username, urlEncodedPassword) |
There was a problem hiding this comment.
Would it be better to construct a url.URL here, then stringify it, to ensure all escaping is correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to the freshly created psql instance, and creates a database if it does not exist.
This closes #3117 with https://github.com/tbdeng/ftl-aws/pull/35
We should refactor the DB creation from the success step to be part of the actual provisioning flow. Thicket for this: #3333
We should also not use the root credentials when connecting to the DB from a module. However, we should change this when looking at DB migrations, when we won't expect modules to execute DDL anymore.